Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5639 - storing the latest selected product type #5752

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • There is a "product type" filter in the search page.
  • The value of this filter wasn't kept for the next search. Now it is.

Fixes bug(s)

Impacted files

  • search_product_helper.dart: initialized and set the latest selected product type
  • user_preferences.dart: new preference field where we store the latest selected product type

Impacted files:
* `search_product_helper.dart`: initialized and set the latest selected product type
* `user_preferences.dart`: new preference field where we store the latest selected product type
@teolemon teolemon added 🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🔎 Search 📸 Open Products Facts 🐾 Open Pet Food Facts labels Oct 27, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 7.01%. Comparing base (4d9c7fc) to head (2214f7f).
Report is 398 commits behind head on develop.

Files with missing lines Patch % Lines
.../lib/data_models/preferences/user_preferences.dart 0.00% 7 Missing ⚠️
...th_app/lib/pages/search/search_product_helper.dart 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5752      +/-   ##
==========================================
- Coverage     9.54%   7.01%   -2.54%     
==========================================
  Files          325     407      +82     
  Lines        16411   21813    +5402     
==========================================
- Hits          1567    1530      -37     
- Misses       14844   20283    +5439     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable behavior

@monsieurtanuki monsieurtanuki merged commit 446a8c0 into openfoodfacts:develop Oct 27, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378 🐾 Open Pet Food Facts 📸 Open Products Facts 🔎 Search
Projects
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Reinit filter product type with the latest value
3 participants